bug(label): hide labelLine on emphasis when emphasis.labelLine.show is false. close #19160 #19165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Ovilia
requested changes
Oct 8, 2023
There was a problem hiding this comment.
This doesn't seem right. ensureState('emphasis') is usually used when you want to set the style of the emphasis state. But in this implementation, the logic is not for emphasis only. Please search the usage of ensureState and try how this should be done. I'm also not sure about this, but this may seem helpful.
Please also add the test case when labelLine.show is set to be false in normal and true in emphasis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Enables hiding of
labelLineon emphasis whenemphasis.labelLine.showisfalse.Fixed issues
Details
Before: What was the problem?
In pie and line charts, when
emphasis.labelLine.showwas set tofalse, the labelLine didn't disappear on emphasis. This was because theemphasisstate didn't exist for labelLine. A similar issue (#16539) was fixed, but the labelLine could be hidden only ifemphasis.labelLine.showwas set totrueand then reset tofalse. If this option was initially set tofalse, it didn't work.After: How does it behave after the fixing?
Now, the emphasis state is ensured for labelLine, which means that labelLine can now be hidden on emphasis if
emphasis.labelLine.showis set tofalse.Document Info
One of the following should be checked.